Clarify the use of JSON in requests and responses #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
commented
Jul 26, 2022
| @@ -196,6 +208,8 @@ only read state (e.g.: `/sync`, get account data, etc). | |||
| The user is unable to reject an invite to join the server notices room. | |||
| See the [Server Notices](#server-notices) module for more information. | |||
|
|
|||
| ### Transaction identifiers | |||
There was a problem hiding this comment.
Gave this a new heading to stop it being stuck under "Other error codes"
richvdh
commented
Jul 26, 2022
| @@ -208,8 +222,6 @@ Some API endpoints may allow or require the use of `POST` requests | |||
| without a transaction ID. Where this is optional, the use of a `PUT` | |||
| request is strongly recommended. | |||
|
|
|||
| {{% http-api spec="client-server" api="versions" %}} | |||
There was a problem hiding this comment.
and moved this into "discovery" (for want of a better place), for the same reason.
richvdh
commented
Jul 26, 2022
uhoreg
reviewed
Jul 26, 2022
uhoreg
approved these changes
Jul 27, 2022
richvdh
commented
Jul 28, 2022
uhoreg
reviewed
Jul 28, 2022
| with the exception of 200 responses to | ||
| [`GET /_matrix/media/v3/download/{serverName}/{mediaId}`](#get_matrixmediav3downloadservernamemediaid) | ||
| and [`GET /_matrix/media/v3/thumbnail/{serverName}/{mediaId}`](#get_matrixmediav3thumbnailservernamemediaid). | ||
| Servers msut include a `Content-Type` header of `application/json` for all JSON responses. |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1182
Preview: https://pr1185--matrix-spec-previews.netlify.app