Spec reference relationships #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
commented
Aug 9, 2022
clokep
reviewed
Aug 15, 2022
richvdh
reviewed
Aug 16, 2022
richvdh
reviewed
Aug 23, 2022
turt2live
commented
Aug 24, 2022
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
reviewed
Sep 27, 2022
| } | ||
| ``` | ||
|
|
||
| The [bundle](#aggregations) under `m.relations` would appear similar to the following: |
There was a problem hiding this comment.
I think this is a bundle, in reference to the same language m.replace uses.
richvdh
approved these changes
Oct 18, 2022
| @@ -2639,4 +2640,5 @@ systems. | |||
| {{< cs-module name="moderation_policies" >}} | |||
| {{< cs-module name="spaces" >}} | |||
| {{< cs-module name="event_replacements" >}} | |||
| {{< cs-module name="threading" >}} | |||
There was a problem hiding this comment.
I noticed recently that I'd forgotten to update the table at https://spec.matrix.org/unstable/client-server-api/#summary for message edits. We should probably do so for threading?
There was a problem hiding this comment.
yea, we should indeed. Will take a look in a different PR.
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
* Spec reference relationships MSC: matrix-org/matrix-spec-proposals#3267 * Apply suggestions from code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Edits per code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC: matrix-org/matrix-spec-proposals#3267
Preview: https://pr1206--matrix-spec-previews.netlify.app