Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec MSC2285: Private read receipts #1216

Merged
merged 7 commits into from Sep 12, 2022
Merged

Spec MSC2285: Private read receipts #1216

merged 7 commits into from Sep 12, 2022

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Aug 25, 2022

@turt2live turt2live marked this pull request as ready for review August 25, 2022 20:23
@turt2live turt2live requested a review from a team as a code owner August 25, 2022 20:23
@turt2live turt2live added this to Requires spec review (post-FCP) in Spec Core Team Backlog Aug 25, 2022
Copy link

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@turt2live
Copy link
Member Author

while we appreciate the support, approving PRs like this does not help them move faster :)

@turt2live turt2live added the release-blocker Blocks the next release from happening label Sep 12, 2022
Copy link
Member

@ara4n ara4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with minor quibbles. very pleasing to see what a simple diff it is in the end to the spec itself :)

Co-authored-by: Matthew Hodgson <matthew@matrix.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker Blocks the next release from happening
Projects
Spec Core Team Backlog
  
Done to some definition
Development

Successfully merging this pull request may close these issues.

None yet

4 participants