improve documentation of ephemeral events #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unenthusiastic, for the reasons set out in #897 (though as @jplatte notes, I'd really prefer to see |
|
I've updated the PR so that they're listed in the /sync documentation, and the other place that discusses them refers to there. |
|
Huh. Should have pressed the "Ready for review" button earlier. :-/ |
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if what I've done here is exactly right, but I think that we need to define ephemeral events in one spot, and then just use the "ephemeral" terminology instead of saying "events that aren't persisted e.g. typing". Opinions on whether this PR looks good, or whether there's a better place to define it, are welcome.
Addresses part of #136
Preview: https://pr1284--matrix-spec-previews.netlify.app