Improve error messages emitted by resolve-additional-types
#1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, it needs an internal changelog |
I forgot to set the `items` on an array definition, and got an extremely opaque error. Hopefully this will improve the lives of anyone who makes a similar mistake in future.
richvdh
force-pushed
the
rav/better-additional-types-errors
branch
from
518be8c
to
8e7ebd5
Compare
anoadragon453
approved these changes
Nov 15, 2022
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
…org#1303) I forgot to set the `items` on an array definition, and got an extremely opaque error. Hopefully this will improve the lives of anyone who makes a similar mistake in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to set the
itemson an array definition, and got an extremelyopaque error. Hopefully this will improve the lives of anyone who makes a
similar mistake in future.
Preview: https://pr1303--matrix-spec-previews.netlify.app