Clarifications to AS spec, including MSC3905 #1305
Conversation
Move the object definition out to yaml files
richvdh
force-pushed
the
rav/appservice_users
branch
from
b385032
to
4ba23ed
Compare
changelogs/application_service/newsfragments/1305.clarification
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Ralston <travisr@matrix.org>
| room IDs. An application service is said to be "interested" in a given event | ||
| if it matches any of the namespaces. |
There was a problem hiding this comment.
| room IDs. An application service is said to be "interested" in a given event | |
| if it matches any of the namespaces. | |
| room IDs. An application service is said to be "interested" in a given event | |
| if it matches any of the namespace regex patterns. |
There was a problem hiding this comment.
Not entirely convinced this is an improvement in clarity, personally. The fact that namespaces are defined via regular expressions is a detail which I think is better left for the formal definition below rather in this overview.
(In any case, we'd want to say "namespace regular expressions" rather than "namespace regex patterns").
There was a problem hiding this comment.
"namespace regular expressions" sounds good to me 👍
I think it makes sense to mention when we're talking about matching. It's immediately apparent and understandable for anyone slightly familiar with regex how it matches then.
Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
|
@MadLittleMods thanks for your review: some great suggestions, which I've tried to incorporate with some light editing. |
Primarily this is the spec for MSC3905, but I've also taken the opportunity to clean up the section a bit and move the definition out to a .yaml file.
Primarily this is the spec for MSC3905, but I've also taken the opportunity to clean up the section a bit and move the definition out to a
.yamlfile.Suggest reviewing commit-by-commit.
Preview: https://pr1305--matrix-spec-previews.netlify.app