Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include examples inline instead of using a reference for invite endpoint definitions #1349

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Nov 17, 2022

The OpenAPI 3.x spec doesn't allow building examples by composition. Either the whole example must be a reference, or all of it has to be included.

This is a prerequisite for #1310.

Signed-off-by: Kévin Commaille zecakeh@tedomum.fr

Preview: https://pr1349--matrix-spec-previews.netlify.app

…nts definitions

The OpenAPI 3 spec doesn't allow building examples by composition.
Either the whole example must be a reference, or it has to be included.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner November 17, 2022 16:46
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh mentioned this pull request Nov 17, 2022
4 tasks
@richvdh richvdh changed the title Include examples parts instead of using a reference for invite endpoi… Include examples inline instead of using a reference for invite endpoint definitions Nov 22, 2022
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@richvdh richvdh enabled auto-merge (squash) November 22, 2022 15:55
@richvdh richvdh merged commit 4534124 into matrix-org:main Nov 22, 2022
@zecakeh zecakeh deleted the invites-examples branch November 28, 2022 11:39
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
…int definitions (matrix-org#1349)

The OpenAPI 3 spec doesn't allow building examples by composition.
Either the whole example must be a reference, or it has to be included.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants