replace "<content>" with "content" #1370
Conversation
This parameter that's part of the content-repo openapi spec causes generators to mess up
|
note: #1310 fixes this |
|
if #1310 fixes this, would it be better to pursue that option instead? |
|
Yes if it were quicker to merge. In this case #1310 can manage the conflicts as long as that means code generators work today. |
|
For the speed the spec moves at, #1310 is likely to land before the next spec release at the current rate - this seems suitable for conde generators too, as using unstable API definitions is, well, unstable. |
There was a problem hiding this comment.
The changes looks good but please add a news fragment, as described here: https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst#adding-to-the-changelog
|
This snippet doesn't even land in the spec text, it seems - and #1310 will have to be updated (merged or rebased) to the latest |
There was a problem hiding this comment.
otherwise lgtm, as it sounds like @KitsuneRal is okay with managing conflicts
Co-authored-by: Travis Ralston <travpc@gmail.com>
|
Awesome thanks |
|
For future changes, please note that we normally require Sign Off to ensure the change can be incorporated into the project. For extraordinarily trivial changes like this however, we tend to bypass this requirement. |
* replace "<content>" with "content" This parameter that's part of the content-repo openapi spec causes generators to mess up * added changelogs * Update changelogs/internal/newsfragments/1370.clarification Co-authored-by: Travis Ralston <travpc@gmail.com> Co-authored-by: Travis Ralston <travpc@gmail.com>
This parameter that's part of the content-repo OpenAPI spec causes generators to mess up.
Preview: https://pr1370--matrix-spec-previews.netlify.app