Fix edu_type on EDU examples
#1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top-level `example` in `edu.yaml` was overriding the individual examples for `edu_type`. Let's fix that by getting rid of the example in `edu.yaml`. Fixes #805
dbkr
approved these changes
Dec 21, 2022
34 tasks
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
The top-level `example` in `edu.yaml` was overriding the individual examples for `edu_type`. Let's fix that by getting rid of the example in `edu.yaml`. Fixes matrix-org#805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top-level
exampleinedu.yamlwas overriding the individual examplesfor
edu_type. Let's fix that by getting rid of the example inedu.yaml.Fixes #805
Preview: https://pr1383--matrix-spec-previews.netlify.app