Improve distinction between tags and their attributes in the rich text section #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t section Originally the tags used to be bold, followed by a colon and separated into two columns in a table. This at least restores the table aspect, which makes it clear, that font is not an attribute (and similar). This seems to have gotten lost in the transition to the new design. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
deepbluev7
force-pushed
the
nico/tag-attributes
branch
from
5a984bf
to
b793121
Compare
|
Very old:
Current:
With this change:
(it's growing!) (Ignore the pink background, that is just how I jump to that spec section) |
uhoreg
approved these changes
Feb 13, 2023
34 tasks
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
…t section (matrix-org#1433) Originally the tags used to be bold, followed by a colon and separated into two columns in a table. This at least restores the table aspect, which makes it clear, that font is not an attribute (and similar). This seems to have gotten lost in the transition to the new design. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the tags used to be bold, followed by a colon and separated into two columns in a table. This at least restores the table aspect, which makes it clear, that font is not an attribute (and similar).
This seems to have gotten lost in the transition to the new design.
Signed-off-by: Nicolas Werner nicolas.werner@hotmail.de
Preview: https://pr1433--matrix-spec-previews.netlify.app