Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify what key content-specific rules match against. #1441

Merged
merged 6 commits into from Mar 8, 2023
Merged

Clarify what key content-specific rules match against. #1441

merged 6 commits into from Mar 8, 2023

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Feb 21, 2023 •
edited by github-actions bot

@clokep clokep marked this pull request as ready for review February 21, 2023 18:24
@clokep clokep requested a review from a team as a code owner February 21, 2023 18:24
@richvdh richvdh self-requested a review February 28, 2023 13:07
@clokep clokep requested a review from richvdh March 6, 2023 16:15
richvdh
richvdh approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great otherwise.

content/appendices.md Outdated Show resolved Hide resolved
content/client-server-api/modules/push.md Show resolved Hide resolved
@clokep @richvdh
Fix typo.
4234447 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@clokep clokep mentioned this pull request Mar 7, 2023
Merged
@clokep
Copy link
Contributor Author

clokep commented Mar 8, 2023

To reiterate -- I think this is ready, I'd like to do some more clean-up here (and kind of have to for MSC3758, MSC3873, and MSC3966) but will do it in follow-ups.

@richvdh
Copy link
Member

richvdh commented Mar 8, 2023

Thanks!

@richvdh richvdh merged commit afae108 into matrix-org:main Mar 8, 2023
@clokep clokep deleted the clokep/push-rule-clarify branch March 8, 2023 13:18
@zecakeh zecakeh mentioned this pull request Mar 23, 2023
Closed
47 tasks
clokep added a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
@clokep
Clarify what key content-specific rules match against. (matrix-org#1441)
b844deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clokep @richvdh