Add a hyphen between third and party when used as an adjective #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'third-party' should have a hyphen when used as an adjective, such as in 'third-party network'. It should not have a dash when used as a noun, such as in 'sharing with a third party'. All uses in the spec of third-party were as an adjective. Thus they have all been updated to include a hyphen where they didn't already.
KitsuneRal
reviewed
Feb 25, 2023
uhoreg
reviewed
Mar 7, 2023
KitsuneRal
approved these changes
Mar 8, 2023
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'third-party' should have a hyphen when used as an adjective, such as in 'third-party network'. It should not have a dash when used as a noun, such as in 'sharing with a third party'.
All uses in the spec of third-party were as an adjective. Thus they have all been updated to include a hyphen where they didn't already.
Additionally, any instance of a capital "Third-Party" has had the word "Party" lowercased. This is mostly personal preference. We use both second-word capitalised and non-capitalised throughout the second (see e-mail, well-known, single sign-on, etc.)
Preview: https://pr1447--matrix-spec-previews.netlify.app