Remove overridden references to examples/minimal_pdu.json and add the missing room_id field.
#1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax is incorrect and would require to use allOf because a $ref can't have siblings. However the only field not overwritten of that definition is room_id, so we include it instead of the $ref Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
changed the title
minimal_pdu.json by the missing room_id fieldexamples/minimal_pdu.json and add the missing room_id field.
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
changed the title
examples/minimal_pdu.json and add the missing room_id field.examples/minimal_pdu.json and add the missing room_id field.
4 tasks
KitsuneRal
approved these changes
Feb 28, 2023
richvdh
approved these changes
Feb 28, 2023
richvdh
reviewed
Feb 28, 2023
47 tasks
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
…he missing `room_id` field. (matrix-org#1454) The syntax is incorrect and would require to use allOf because a $ref can't have siblings. However the only field not overwritten of that definition is room_id, so we include it instead of the $ref Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1310 (comment).
The syntax is incorrect and would require to use
allOfbecause a$refcan't have siblings.However the only field not overwritten of that definition is
room_id, so we include it instead of the$ref.Pre-requisite for #1310.
Signed-off-by: Kévin Commaille zecakeh@tedomum.fr
Preview: https://pr1454--matrix-spec-previews.netlify.app