Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleanup before upgrading to OpenAPI 3.1 #1455

Merged
merged 4 commits into from Mar 8, 2023

Conversation

KitsuneRal
Copy link
Member

@KitsuneRal KitsuneRal commented Feb 28, 2023

  • capabilities.yaml: additional properties are actually more likely to be strings (but can also be objects)
  • cross_signing_key.yaml: the parameter documentation already restricts the number of properties
  • receipts.yaml: use maxProperties: 0 to say the object is empty (the comment is still there but is not really needed any more)

Signed-off-by: Alexey Rusakov <Kitsune.Ral@users.sf.net>

Preview: https://pr1455--matrix-spec-previews.netlify.app

In capabilities.yaml, additional properties are more likely to be
strings (but can also be objects); in cross_signing_key.yaml,
the parameter documentation already restricts the number of properties.
@KitsuneRal KitsuneRal marked this pull request as ready for review February 28, 2023 13:59
@KitsuneRal KitsuneRal requested a review from a team as a code owner February 28, 2023 13:59
@KitsuneRal KitsuneRal changed the title Cleanup additionalProperties usage More cleanup before upgrading to OpenAPI 3.1 Feb 28, 2023
@richvdh richvdh merged commit b441b19 into main Mar 8, 2023
@richvdh richvdh deleted the kitsune/cleanup-additional-properties branch March 8, 2023 10:39
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
 * `cross_signing_key.yaml`: the parameter documentation already restricts the number of properties
 * `receipts.yaml`: use `maxProperties: 0` to say the object is empty (the comment is still there but is not really needed any more)
 
Signed-off-by: Alexey Rusakov <Kitsune.Ral@users.sf.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants