Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct a small typo in the push rules spec #1465

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Correct a small typo in the push rules spec #1465

merged 2 commits into from
Mar 14, 2023

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Mar 14, 2023 •
edited by github-actions bot
Loading

This PR fixes a field name in an example that does not make sense.

The example does not talk about a "membership" field in any case. It looks like this was instead supposed to be "topic", as the previous paragraph also talks about.

Preview: https://pr1465--matrix-spec-previews.netlify.app

@anoadragon453
Correct a typo in a field name
93249ef 
This example does not talk about a 'membership' field in any case.
It looks like this was instead supposed to be 'topic', as the
previous paragraph also talks about.
@anoadragon453
changelog
81c81a2
@anoadragon453 anoadragon453 marked this pull request as ready for review March 14, 2023 15:38
@anoadragon453 anoadragon453 requested a review from a team as a code owner March 14, 2023 15:38
clokep
clokep approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I noticed in this #1464 and failed to update it. 😢

@anoadragon453
Copy link
Member Author

anoadragon453 commented Mar 14, 2023 •
edited
Loading

Oh I noticed in this #1464 and failed to update it. cry

Your PR made me notice it, so in the end it still helped fixed it ✨

I'm going to take Patrick's review as an approval of this typo fix.

@anoadragon453 anoadragon453 changed the title Correct a small typo in the push rules spec Correct a small typo in the push rules spec (#1465 Mar 14, 2023
@anoadragon453 anoadragon453 merged commit 35f5439 into main Mar 14, 2023
@anoadragon453 anoadragon453 deleted the anoa/topic_typo branch March 14, 2023 15:43
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
@anoadragon453 @clokep
Correct a small typo in the push rules spec (matrix-org#1465
d338b16
@turt2live
Copy link
Member

(ftr, force-merge bypassed the changelog check: .clarification is not plural. Will fix out of band)

@anoadragon453 anoadragon453 changed the title Correct a small typo in the push rules spec (#1465 Correct a small typo in the push rules spec May 24, 2023
@anoadragon453
Copy link
Member Author

anoadragon453 commented May 24, 2023 •
edited
Loading

@turt2live I didn't perform a force merge, and the CI passed: https://github.com/matrix-org/matrix-spec/actions/runs/4417512313/jobs/7743320855#step:3:7

Though it looks like the CI only checks that the changelog file is in a valid directory, and has the right number. It does not check that it has a valid extension: https://github.com/matrix-org/matrix-spec/blob/db0fd307447edeb5724c9897e07e6c56d87123f6/scripts/check-newsfragments

@turt2live
Copy link
Member

I swear yesterday it was saying the ci partially passed :(

Sorry, and good spot: we should fix that workflow.

@zecakeh zecakeh mentioned this pull request May 24, 2023
Closed
47 tasks
@anoadragon453 anoadragon453 mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anoadragon453 @turt2live @clokep