Remove outdated text saying that state_default defaults to 0 #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Mar 31, 2023
Comment on lines
-79
to
-80
| **Note**: When there is no `m.room.power_levels` event in the room, this defaults | ||
| to 0. See description for more information. |
There was a problem hiding this comment.
I probably should have done it in my original PR, but while you're here it'd be good to have a similar note for the "creator gets 100" clause on users_default (effectively).
There was a problem hiding this comment.
Added a note in 4a90545 (and clarified the rest of the description of users_default too
turt2live
added a commit
to matrix-org/eigen-server
that referenced
this pull request
Mar 31, 2023
47 tasks
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
…org#1479) There was substantial confusion around this, but I've done some archaeology. Basically, this was changed back in r0.5.0 by MSC1304 and matrix-org/synapse#3397. Before that, it was indeed the case that state_default was 0 if there was no m.room.power_levels event, but that was confusing and a source of security holes, so we changed it. matrix-org/matrix-spec-proposals#1656 changed the spec, but apparently overlooked the text in the description. Reverts: matrix-org#1478. Fixes: matrix-org#861.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was substantial confusion around this, but I've done some archaeology.
Basically, this was changed back in r0.5.0 by MSC1304 and matrix-org/synapse#3397. Before that, it was indeed the case that
state_defaultwas 0 if there was nom.room.power_levelsevent, but that was confusing and a source of security holes, so we changed it.matrix-org/matrix-spec-proposals#1656 changed the spec, but apparently overlooked the text in the description.
Reverts: #1478.
Fixes: #861.
Preview: https://pr1479--matrix-spec-previews.netlify.app