Fix generation of anchors for additional properties #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but objects defined under `additionalProperties` missed out on them. This fixes that.
|
I don't understand how the change fixes the issue. I'm inclined to believe that it does, but could you provide a link to a place in the spec where we can see where the change makes a difference? |
|
Sorry yes, this is a bit obscure. Here's one example: https://pr1488--matrix-spec-previews.netlify.app/client-server-api/#_matrixclientv3roomsroomidjoined_members_roommember. |
uhoreg
approved these changes
Apr 29, 2023
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
but objects defined under `additionalProperties` missed out on them. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1174 added HTML anchors for object definitions, but objects defined under
additionalPropertiesmissed out on them. This fixes that.Preview: https://pr1488--matrix-spec-previews.netlify.app