Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec asynchronous uploads #1499

Merged
merged 6 commits into from May 3, 2023
Merged

Spec asynchronous uploads #1499

merged 6 commits into from May 3, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 25, 2023

@richvdh richvdh requested a review from a team as a code owner April 25, 2023 14:14
Comment on lines +112 to +121
- in: header
name: Content-Type
type: string
description: The content type of the file being uploaded
x-example: "application/pdf"
- in: query
type: string
x-example: "War and Peace.pdf"
name: filename
description: The name of the file being uploaded
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Sumner Evans <me@sumnerevans.com>
@richvdh
Copy link
Member Author

richvdh commented Apr 25, 2023

@sumnerevans thanks!

Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than a nit

data/api/client-server/content-repo.yaml Outdated Show resolved Hide resolved
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@richvdh richvdh enabled auto-merge (squash) May 3, 2023 12:39
@richvdh richvdh merged commit 283c587 into main May 3, 2023
10 checks passed
@richvdh richvdh deleted the rav/spec_asynchronous_media branch May 3, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants