Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"MXC URI" -> "mxc:// URI" #1500

Merged
merged 3 commits into from Apr 26, 2023
Merged

"MXC URI" -> "mxc:// URI" #1500

merged 3 commits into from Apr 26, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 25, 2023 •
edited by github-actions bot

We're a bit inconsistent with this currently, and IMHO "mxc:// URI" is more
explicit.

Preview: https://pr1500--matrix-spec-previews.netlify.app

@richvdh
"MXC URI" -> "mxc:// URI"
61fb66d 
We're a bit inconsistent with this currently, and IMHO "`mxc://` URI" is more
explicit.
@richvdh richvdh requested a review from a team as a code owner April 25, 2023 14:59
uhoreg
uhoreg reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also:

  • an "mxc avatar url" in data/api/client-server/rooms.yaml,
  • a "Matrix Content (MXC) URL" in content/client-server-api/modules/instant_messaging.md

content/client-server-api/modules/content_repo.md Outdated Show resolved Hide resolved
richvdh and others added 2 commits April 26, 2023 12:42
@richvdh @uhoreg
Update content/client-server-api/modules/content_repo.md
3d792b1 
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@richvdh
more MXCs
5275871
@richvdh
Copy link
Member Author

richvdh commented Apr 26, 2023

thanks @uhoreg , good spots!

@richvdh richvdh requested a review from uhoreg April 26, 2023 11:50
@richvdh richvdh merged commit 1f729ee into main Apr 26, 2023
10 checks passed
@richvdh richvdh deleted the rav/mxc_uri branch April 26, 2023 13:11
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
@richvdh @uhoreg @clokep
"MXC URI" -> "mxc:// URI" (matrix-org#1500)
992e2ba 
* "MXC URI" -> "`mxc://` URI"

We're a bit inconsistent with this currently, and IMHO "`mxc://` URI" is more
explicit.

* Update content/client-server-api/modules/content_repo.md

Co-authored-by: Hubert Chathi <hubertc@matrix.org>

* more MXCs

---------

Co-authored-by: Hubert Chathi <hubertc@matrix.org>
@zecakeh zecakeh mentioned this pull request May 4, 2023
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richvdh @uhoreg