-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spec for MSC3952: intentional mentions #1508
Conversation
d7dbae2
to
095baab
Compare
095baab
to
45261ea
Compare
I think this is going to need a bit more work, but it is ready for an initial round of review. |
Co-authored-by: Marcel <MTRNord@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks great! I just have a few changes requested below.
Edit: Sorry, ignore this. It was for a GitHub demo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @clokep! A few thoughts and comments
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@richvdh Thank you very much for the review! I'm quite sure this will need a bit more back and forth, but I've handled your comments or replied to them (I've left open the threads I consider unresolved). Please take another look at your leisure! |
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@richvdh I've handled all those comments! I'm not sure if there's anything to do about the special behavior discussed in #1508 (comment), however. |
Yes, this is probably the best we can do for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
See MSC3952.
Preview: https://pr1508--matrix-spec-previews.netlify.app