Add missing type enum for m.reaction

[chebureki]

The specification does not specify the m.reaction for the event type

Preview: https://pr1552--matrix-spec-previews.netlify.app

[richvdh]

Thanks! Please could you include a newsfragment file, per https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst#adding-to-the-changelog?

Please try to phrase it in terms of the change to the rendered spec.

[chebureki]

Thanks! Please could you include a newsfragment file, per https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst#adding-to-the-changelog?

Please try to phrase it in terms of the change to the rendered spec.

just did :)

[richvdh]

@chebureki are you still interested in working on this?

[chebureki]

@chebureki are you still interested in working on this?

I apologize, got busy with life.
We could rephrase it as. If you have a better idea, feel free to change it :)

Fixed missing type field for reaction event

[richvdh]

Wait, does this actually change the content of the spec at all?

https://pr1552--matrix-spec-previews.netlify.app/client-server-api/#mreaction looks identical to https://spec.matrix.org/v1.7/client-server-api/#mreaction

[chebureki]

Wait, does this actually change the content of the spec at all?

https://pr1552--matrix-spec-previews.netlify.app/client-server-api/#mreaction looks identical to https://spec.matrix.org/v1.7/client-server-api/#mreaction

It doesn't change the the appearance of the spec :) !
For a project of mine, I do code generation.
If you don't specify this value, it will simply have the string type.
If you specify this value, it will know to use this specific value

[richvdh]

Thanks; sorry it took me a while to grok what was going on here.