Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null in room_types for POST /publicRooms endpoints #1564

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Jun 10, 2023

Also fixes rendering of type as an array.

Note that this will probably conflict with #1559, as it edits a similar area of partials/openapi/render-object-table.html.

Preview: https://pr1564--matrix-spec-previews.netlify.app

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner June 10, 2023 10:00
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me!

@erikjohnston erikjohnston merged commit 49957be into matrix-org:main Jun 13, 2023
10 checks passed
@zecakeh zecakeh deleted the fix-room-types-null branch June 13, 2023 14:23
@zecakeh zecakeh mentioned this pull request Aug 21, 2023
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants