Render binary request and response bodies #1579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two first commits are cleanups necessary before making the spec rendering work.
The idea is to use a different kind of table when the data is not JSON.
Here is what it looks like for a request (notice that the quotes around the example are removed):
This is the same for a response:
And here is the 200 response of
GET /_matrix/media/v3/thumbnail/{serverName}/{mediaId}
, with 2 content types:Preview: https://pr1579--matrix-spec-previews.netlify.app