Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary oneOfs in JSON schemas #1585

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Remove unnecessary oneOfs in JSON schemas #1585

merged 2 commits into from
Jun 23, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Jun 22, 2023 •
edited by github-actions bot
Loading

oneOf is only necessary if there are more fields than the type.

Preview: https://pr1585--matrix-spec-previews.netlify.app

@zecakeh
Remove unnecessary oneOfs in JSON schemas
bd39a9c 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner June 22, 2023 13:06
@zecakeh
Add changelog
3eef32e 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
KitsuneRal
KitsuneRal approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair and square :)

@KitsuneRal KitsuneRal merged commit 30845e1 into matrix-org:main Jun 23, 2023
10 checks passed
@zecakeh zecakeh deleted the remove-oneof branch June 23, 2023 13:42
@zecakeh zecakeh mentioned this pull request Aug 21, 2023
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zecakeh @KitsuneRal