Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that via is required for m.space.parent and m.space.child as per MSC1772. #1618

Merged
merged 4 commits into from Sep 5, 2023
Merged

Clarify that via is required for m.space.parent and m.space.child as per MSC1772. #1618

merged 4 commits into from Sep 5, 2023

Conversation

PaarthShah
Copy link
Contributor

@PaarthShah PaarthShah commented Aug 18, 2023 •
edited by github-actions bot

Per MSC1772 (emphasis mine):

  • m.space.child

The admins of a space can advertise rooms and subspaces for their space by setting m.space.child state events. The state_key is the ID of a child room or space, and the content must contain a via key which gives a list of candidate servers that can be used to join the room.

  • m.space.parent

Similar to m.space.child, the state_key is the ID of the parent space, and the content must contain a via key which gives a list of candidate servers that can be used to join the parent.

I was made aware of this by this issue.

Preview: https://pr1618--matrix-spec-previews.netlify.app

@PaarthShah PaarthShah requested a review from a team as a code owner August 18, 2023 07:49
turt2live
turt2live previously requested changes Aug 18, 2023
View reviewed changes
data/event-schemas/schema/m.space.child.yaml Outdated Show resolved Hide resolved
@turt2live turt2live requested review from a team and removed request for turt2live August 20, 2023 01:03
anoadragon453
anoadragon453 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for catching and acting on this!

changelogs/client_server/newsfragments/1618.clarification Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 enabled auto-merge (squash) September 5, 2023 13:46
@anoadragon453 anoadragon453 merged commit 838dec2 into matrix-org:main Sep 5, 2023
10 checks passed
This was referenced Sep 15, 2023
Merged
Closed
@zecakeh zecakeh mentioned this pull request Oct 25, 2023
Open
@PaarthShah PaarthShah mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@turt2live turt2live turt2live left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PaarthShah @turt2live @anoadragon453