Fix schema of m.mentions object
#1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
clokep
reviewed
Sep 12, 2023
| @@ -18,17 +18,13 @@ description: |- | |||
| Describes whether the event mentions other users or the room. This is contained | |||
| within the event's `content` alongside other fields for the relevant event type. | |||
| example: { | |||
There was a problem hiding this comment.
My thinking when doing this was to keep the example the same across spec v1.6 and 1.7, see:
There was a problem hiding this comment.
I see. I guess that example should be included directly in the spec rather than in the JSON schema, then?
The reason I stumbled upon this is that I'd like to add a tool that validates all JSON schemas in CI. This one would not pass as the example doesn't match the schema.
There was a problem hiding this comment.
That might be better, yeah.
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was not how a string of arrays is declared. Also the example was for a full event, instead of just the
m.mentionsobject.Preview: https://pr1635--matrix-spec-previews.netlify.app