Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema of m.receipt EDU #1636

Merged
merged 4 commits into from Sep 19, 2023
Merged

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Sep 12, 2023

It was missing a nesting level for the user ID -> user read receipt map.

Preview: https://pr1636--matrix-spec-previews.netlify.app

It was missing a nesting level for the user ID -> user read receipt map.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner September 12, 2023 14:19
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@richvdh
Copy link
Member

richvdh commented Sep 19, 2023

A few links:

changelogs/internal/newsfragments/1636.clarification Outdated Show resolved Hide resolved
Comment on lines +45 to +46
additionalProperties:
type: object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should document what the key of the object is (the user id), much as we do for the content object above it:

Receipts for a particular room. The string key is the room ID for
which the receipts under it belong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I documented it

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh merged commit 96f88e0 into matrix-org:main Sep 19, 2023
10 checks passed
@zecakeh zecakeh deleted the fix-receipt-edu branch September 19, 2023 15:59
@zecakeh zecakeh mentioned this pull request Nov 30, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants