Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "case sensitive" to /publicRooms #1638

Merged
merged 3 commits into from
Sep 19, 2023
Merged

add "case sensitive" to /publicRooms #1638

merged 3 commits into from
Sep 19, 2023

Conversation

mohit1523
Copy link
Contributor

@mohit1523 mohit1523 commented Sep 14, 2023

Fixes #1619

This PR add the "case sensitive" to the server specs of /publicRooms so that client should lowercase it before sending.

Screenshot 2023-09-14 233219

Preview: https://pr1638--matrix-spec-previews.netlify.app

@mohit1523 mohit1523 requested a review from a team as a code owner September 14, 2023 18:08
@mohit1523 mohit1523 changed the title [feat] : adds "case sensitive" to the /publicRooms [clarification] : adds "case sensitive" to the /publicRooms Sep 19, 2023
@richvdh richvdh changed the title [clarification] : adds "case sensitive" to the /publicRooms add "case sensitive" to the /publicRooms Sep 19, 2023
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@richvdh
Copy link
Member

richvdh commented Sep 19, 2023

I'm supposed to ask you for sign off but since it's only 4 words we'll take the risk that you won't sue us

@richvdh richvdh changed the title add "case sensitive" to the /publicRooms add "case sensitive" to /publicRooms Sep 19, 2023
@richvdh richvdh enabled auto-merge (squash) September 19, 2023 14:49
@mohit1523
Copy link
Contributor Author

mohit1523 commented Sep 19, 2023

I'm supposed to ask you for sign off but since it's only 4 words we'll take the risk that you won't sue us

Thanks to you sir 😄🙏

@richvdh richvdh merged commit 46447e0 into matrix-org:main Sep 19, 2023
10 checks passed
@zecakeh zecakeh mentioned this pull request Nov 30, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server names are case sensitive in /publicRooms
2 participants