Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that an m.room.name event with an absent name field is not expected behavior #1639

Merged
merged 2 commits into from Sep 19, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Sep 18, 2023

Fixes #1632

For me the "if" makes a lot of difference in understanding that the paragraph does not mean that it should be the expected behavior.

Preview: https://pr1639--matrix-spec-previews.netlify.app

…t expected behavior

Fixes matrix-org#1632

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner September 18, 2023 12:37
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much clearer, thanks!

@richvdh richvdh merged commit 044a787 into matrix-org:main Sep 19, 2023
10 checks passed
@zecakeh zecakeh deleted the clarify-room-name-absent branch September 19, 2023 14:47
@zecakeh zecakeh mentioned this pull request Nov 30, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

m.room.name's name field is marked as required but is described as possibly absent
2 participants