Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in canonical JSON grammar #1652

Merged
merged 4 commits into from Oct 2, 2023
Merged

Conversation

tsufeki
Copy link
Contributor

@tsufeki tsufeki commented Oct 2, 2023

Fixes typo concerning array end delimiter in canonical JSON grammar.

I've also changed all hex numbers to upper case there, I'm not sure if this is worthwhile (those are lower case in the IETF RFC).

Signed-off-by: Benedykt Błaszkiewicz <tsufeki@gmail.com>
Signed-off-by: Benedykt Błaszkiewicz <tsufeki@gmail.com>
Signed-off-by: Benedykt Błaszkiewicz <tsufeki@gmail.com>
@tsufeki tsufeki marked this pull request as ready for review October 2, 2023 12:00
@tsufeki tsufeki requested a review from a team as a code owner October 2, 2023 12:00
Signed-off-by: Benedykt Błaszkiewicz <tsufeki@gmail.com>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!

@richvdh richvdh enabled auto-merge (squash) October 2, 2023 12:12
@richvdh
Copy link
Member

richvdh commented Oct 2, 2023

I've also changed all hex numbers to upper case there, I'm not sure if this is worthwhile (those are lower case in the IETF RFC).

I don't feel strongly about upper vs lower, but consistency is certainly good.

@richvdh richvdh merged commit 92cf662 into matrix-org:main Oct 2, 2023
10 checks passed
@zecakeh zecakeh mentioned this pull request Nov 30, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants