Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in "Event annotations" module #1658

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix typo in "Event annotations" module #1658

merged 1 commit into from
Oct 11, 2023

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Oct 4, 2023

@nabijaczleweli nabijaczleweli requested a review from a team as a code owner October 4, 2023 16:12
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that!

@KitsuneRal
Copy link
Member

One small thing: can you add a newsfragment please?

@nabijaczleweli
Copy link
Contributor Author

no clue what you mean by this, so no, sorry

@richvdh richvdh changed the title annotion fix typo in "Event annotations" module Oct 4, 2023
@richvdh
Copy link
Member

richvdh commented Oct 4, 2023

@nabijaczleweli
Copy link
Contributor Author

applied

@@ -0,0 +1 @@
event_annotations: annotion => annotation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually for this sort of thing we normally just use

Suggested change
event_annotations: annotion => annotation
Fix various typos throughout the specification.

(See https://spec.matrix.org/v1.8/changelog/#client-server-api for example)

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli
Copy link
Contributor Author

applied

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's fine for this trivial PR, but for future reference, please don't force-push after a review - it makes it very hard to see what has changed.

@richvdh richvdh enabled auto-merge (squash) October 11, 2023 06:04
@richvdh richvdh merged commit 7fb9e99 into matrix-org:main Oct 11, 2023
10 checks passed
@zecakeh zecakeh mentioned this pull request Nov 30, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants