Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub actions #1660

Merged
merged 5 commits into from Oct 11, 2023
Merged

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Oct 5, 2023

Removes some warnings in CI.

Part of #1356.

Preview: https://pr1660--matrix-spec-previews.netlify.app

Gets rid of warning in CI complaining about those actions
using node 12.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Use the latest LTS

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner October 5, 2023 14:41
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@richvdh
Copy link
Member

richvdh commented Oct 10, 2023

Sorry to be a pain, but can you separate the typo fixes to a separate PR?

(we normally use "Fix various typos throughout the specification." as the changelog for such things)

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@zecakeh
Copy link
Contributor Author

zecakeh commented Oct 11, 2023

I reverted the changes for the typos

@zecakeh zecakeh requested a review from richvdh October 11, 2023 07:49
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@richvdh richvdh merged commit c71b528 into matrix-org:main Oct 11, 2023
10 checks passed
@zecakeh zecakeh deleted the upgrade-github-actions branch October 11, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants