Federation requests must be for local users. #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
approved these changes
Nov 14, 2023
| @@ -121,7 +121,7 @@ paths: | |||
| parameters: | |||
| - in: query | |||
| name: user_id | |||
| description: The user ID to query. | |||
| description: The user ID to query. Must be a user local to the receiving homeserver. | |||
There was a problem hiding this comment.
this is already mentioned in the description. I suppose there is no harm in repeating it.
|
Thanks for the review! 🎉 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already mentioned for
/user/devices, but is not mentioned for/query/profile,/user/keys/claim, or/user/keys/query.See GHSA-mp92-3jfm-3575 for an issue found with this in Synapse.
@turt2live suggested this be a spec clarification as opposed to an MSC. I didn't spec what a homeserver should do in this case, although it is my opinion that the invalid requests should be rejected outright.
Preview: https://pr1672--matrix-spec-previews.netlify.app