Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch receipts by thread as well as room #1685

Merged

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Dec 1, 2023

Fixes #1684

Avoid implying receipts for the same user+room but different threads should be batched together, since the JSON format does not allow it.

Preview: https://pr1685--matrix-spec-previews.netlify.app

Signed-off-by: Andy Balaam <andy.balaam@matrix.org>
Signed-off-by: Andy Balaam <andy.balaam@matrix.org>
@andybalaam andybalaam marked this pull request as ready for review December 1, 2023 09:26
@andybalaam andybalaam requested a review from a team as a code owner December 1, 2023 09:26
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm

@richvdh richvdh enabled auto-merge (squash) December 5, 2023 16:27
@richvdh richvdh merged commit 3b2146c into matrix-org:main Dec 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batching receipts should be per room/thread, not just per room
2 participants