Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that extra fields of space hierarchy children are not required #1741

Merged
merged 2 commits into from Mar 7, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Mar 5, 2024

There is no children_state field, the room_type is only set for spaces and the description of allowed_room_ids says that the field can be omitted.

Preview: https://pr1741--matrix-spec-previews.netlify.app

There is no `children_state` field,
the `room_type` is only set for spaces
and the description of `allowed_room_ids` says that the field can be omitted.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner March 5, 2024 15:45
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Contributor

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct.

@clokep
Copy link
Contributor

clokep commented Mar 5, 2024

Kind of related to #1729.

@clokep clokep merged commit a1210ff into matrix-org:main Mar 7, 2024
12 checks passed
@zecakeh zecakeh deleted the ss-space-hierarchy-child-required branch March 7, 2024 10:06
@zecakeh zecakeh mentioned this pull request Mar 7, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants