Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar for room IDs (SPEC-389) #175

Open
matrixbot opened this issue Apr 19, 2016 · 6 comments
Open

Grammar for room IDs (SPEC-389) #175

matrixbot opened this issue Apr 19, 2016 · 6 comments
Labels
feature Suggestion for a significant extension which needs considerable consideration p1

Comments

@matrixbot
Copy link
Member

matrixbot commented Apr 19, 2016

Room IDs (and Event IDs, prior to room v3) are opaque to the user (they should never be seen), but they do have some syntax within the protocol; this means that they can be more baroque than User IDs, but are not as freeform as some other IDs (https://github.com/matrix-org/matrix-doc/issues/666).

We should ensure their syntax is well-specified, and make sure we know which characters they can include.

(Imported from https://matrix.org/jira/browse/SPEC-389)

(Reported by @richvdh)

@matrixbot
Copy link
Member Author

Jira watchers: @richvdh

@matrixbot
Copy link
Member Author

matrixbot commented Apr 19, 2016

Links exported from Jira:

relates to SPEC-1
relates to matrix-org/matrix-spec-proposals#668

@matrixbot
Copy link
Member Author

From [~markjh]:

... the v2 filter API makes assumptions that '*" is not a valid character in a room id or a user ID so that it can use it as a wildcard.

-- @richvdh

@matrixbot
Copy link
Member Author

matrixbot commented Jul 13, 2016

The local-part could have the same grammar as the completely-opaque IDs (https://github.com/matrix-org/matrix-doc/issues/666)?

-- @richvdh

@matrixbot
Copy link
Member Author

matrixbot commented Jul 22, 2016

Probably also relevant to https://github.com/matrix-org/matrix-doc/issues/666, the character set should probably be limited to avoid things that would be ambiguous or "annoying" when displayed, like whitespace and newlines. Also, if the opaque ID can contain a colon, that would make it harder to figure out which colon delimits the opaque ID from the IP/hostname and from the port.

-- Jimmy Cuadra

@matrixbot matrixbot added the p1 label Oct 28, 2016
@matrixbot matrixbot changed the title Grammar for room IDs and event IDs Grammar for room IDs and event IDs (SPEC-389) Oct 31, 2016
@matrixbot matrixbot added the feature Suggestion for a significant extension which needs considerable consideration label Nov 7, 2016
@turt2live turt2live self-assigned this Sep 6, 2018
@turt2live turt2live removed their assignment Sep 14, 2018
@richvdh richvdh changed the title Grammar for room IDs and event IDs (SPEC-389) Grammar for room IDs (SPEC-389) May 9, 2019
@richvdh
Copy link
Member

richvdh commented Sep 30, 2020

As reflected in matrix-org/synapse#8409, allowing / in room ids causes issues with apache rejecting %2F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Suggestion for a significant extension which needs considerable consideration p1
Projects
None yet
Development

No branches or pull requests

3 participants