Fix security schemes in OpenAPI definitions #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `Authorization: Bearer` possibility. Also clarifies on two endpoints that only an appservice access token can be used. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
$ref is not authorized for the full object. Each scheme must be referenced individually. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Use the recommended way of declaring the `Authorization: Bearer` header. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
$ref is not authorized for the full object. Each scheme must be referenced individually. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
$ref is not authorized for the full object. Each scheme must be referenced individually. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Use the recommended way of declaring HTTP Authorization header. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
$ref is not authorized for the full object. Each scheme must be referenced individually. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
KitsuneRal
approved these changes
Mar 30, 2024
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are not a lot of different changes but there is a lot of search & replace.
The changes are:
Authorization: Bearersecurity scheme as a different possibility to the query parameter for the client-server and identity APIs.$refproperly to reuse the security schemes. It's a bit more verbose as each scheme needs to be imported individually.This can be reviewed per commit.
There is no difference in the spec output, only in the OpenAPI output.
Preview: https://pr1772--matrix-spec-previews.netlify.app