Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hugo warnings #1775

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Fix Hugo warnings #1775

merged 3 commits into from
Apr 9, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Apr 3, 2024

There was, when building Hugo on recent versions, 1 warning on 0.113.0 in CI, and another one on 0.121.2 on my machine. This gets rid of them.

The first commit bumps the minimum supported Hugo version to the one used in CI so we can just handle the deprecated settings without keeping backwards compatibility.

Preview: https://pr1775--matrix-spec-previews.netlify.app

There were new deprecations in Hugo 0.112.
Bumping the minimum version allows to remove them without worrying about older version.
It is set to the version used in CI.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner April 3, 2024 09:46
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks that taxonomyTerm has been replaced by taxonomy, so indeed it makes no sense to have both in our config file.

Thanks for this!

@anoadragon453 anoadragon453 merged commit e74c7c1 into matrix-org:main Apr 9, 2024
12 checks passed
@zecakeh zecakeh deleted the hugo-warnings branch April 9, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants