Upgrade version of Hugo used to build the spec in CI #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
The behavior of `delimit` changed, so Hugo doesn't recognize "safe" HTML passed to it anymore, so it escapes nested HTML links. To fix that we escape the schema data manually and consider the output of the partial as "safe". Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
richvdh
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped to Hugo 0.124.1, because there is an incompatibility with docsy in the latest version (0.125.0): google/docsy#1930.
The second commit is a fix for the rendered spec in the
render-object-tablepartial.The behavior of
delimitchanged, Hugo doesn't recognize "safe" HTML passed to it anymore, so it escapes nested HTML links even if they were marked as "safe", like this:To fix that we escape the schema data manually and consider the output of the
property-typepartial as "safe".I usually do a diff to check if there are visible changes in the rendered spec. Sadly, it seems that the way that URLs are built has changed (most of them are absolute now when they where relative before), so the diff is filled with that. I didn't notice any other change in the rendered spec though.
Preview: https://pr1794--matrix-spec-previews.netlify.app