Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OneTimeKeys schema #1800

Merged
merged 3 commits into from Apr 30, 2024
Merged

Use OneTimeKeys schema #1800

merged 3 commits into from Apr 30, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Apr 24, 2024

This was commented prior to the port to OpenAPI 3.1 for technical reasons (#1127). Now we can use it just fine.

I am wondering if the oneOf: [string, KeyObject] is right, since the section about one-time and fallback keys clearly says that only signed_curve25519 is used in this case.

This adds the KeyObject definition in several places:

image

Preview: https://pr1800--matrix-spec-previews.netlify.app

This was commented prior to the
port to OpenAPI 3.1 for technical reasons (matrix-org#1127).
Now we can use it just fine.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner April 24, 2024 09:54
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@richvdh
Copy link
Member

richvdh commented Apr 24, 2024

This isn't really rendering right in the preview - it's referring to a OneTimeKeys type which is then not defined. Is that something that is fixed by one of the other PRs in flight?

image

I am wondering if the oneOf: [string, KeyObject] is right, since the section about one-time and fallback keys clearly says that only signed_curve25519 is used in this case.

Yeah. I think the problem is that, previously, curve25519 was used here, where the type is just string. I think it's fair to say that nobody should be using unsigned curve25519 keys here, but maybe that is a separate change?

@zecakeh
Copy link
Contributor Author

zecakeh commented Apr 24, 2024

This isn't really rendering right in the preview - it's referring to a OneTimeKeys type which is then not defined. Is that something that is fixed by one of the other PRs in flight?

Yes, that is fixed by #1801. Or an alternative is to remove the title.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right now! 🎉

@richvdh richvdh merged commit 2d18aac into matrix-org:main Apr 30, 2024
12 checks passed
@zecakeh zecakeh deleted the one-time-keys branch April 30, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants