Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering string formats #1814

Merged
merged 2 commits into from
May 8, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented May 3, 2024

Similar to #1796, but for property values instead of property names. Currently only non-custom formats are defined for strings in OpenAPI definitions so I decided to add support for the uri format to have something to see.

For example:

image

Preview: https://pr1814--matrix-spec-previews.netlify.app

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner May 3, 2024 15:52
@zecakeh zecakeh changed the title Add support for string formats Add support for rendering string formats May 3, 2024
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does what it says it does. Thanks

@uhoreg uhoreg merged commit 98d85cf into matrix-org:main May 8, 2024
12 checks passed
@zecakeh zecakeh deleted the string-format branch May 8, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants