Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up pull request template #1831

Merged
merged 1 commit into from
May 31, 2024
Merged

Clean up pull request template #1831

merged 1 commit into from
May 31, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 28, 2024

As far as I can tell, these header lines only encourage people to create badly-formatted PRs.

Also we only have one template so let's give it the default name.

Preview: https://pr1831--matrix-spec-previews.netlify.app

As far as I can tell, these header files only encourage people to create
badly-formatted PRs.

Also we only have one template so let's give it the default name.
@richvdh richvdh requested a review from a team as a code owner May 28, 2024 12:56
@erikjohnston
Copy link
Member

Do you have an example of what this looks like? When I try and make a PR currently it seems to just give an empty box :/

@richvdh
Copy link
Member Author

richvdh commented May 29, 2024

The thing I'm trying to fix is stuff like #1830.

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean sure why not.

Though I don't fully understand why I don't get PR templates :(

@tulir
Copy link
Member

tulir commented May 29, 2024

When I try and make a PR currently it seems to just give an empty box :/

I think that's because github's web UI doesn't support having multiple (named) PR templates, so when there's no default, it just doesn't show a template at all.

GitHub CLI does support those named templates, but it doesn't support the metadata section at the beginning

@sumnerevans
Copy link
Contributor

sumnerevans commented May 30, 2024

I wasn't really sure what to put in that section, but it just keeps showing up whenever I do gh pr create which is the main way that I create PRs. It didn't really make sense to just copy the title and description that I already had written, so I just left it.

(I thought that it might be some sort of automation or accounting that was needed by some sort of process for the repo, so I just left it.)

@richvdh richvdh merged commit 722c2b1 into main May 31, 2024
12 checks passed
@richvdh richvdh deleted the rav/fix_pr_template branch May 31, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants