Add authenticated media (MSC3916) #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
force-pushed
the
travis/media-auth
branch
from
573c0aa
to
d8c4975
Compare
The server-server spec might have a harder time linking to these, but that can be fixed with verbiage.
This is largely a copy/paste of the new authed content repo API in the Client-Server API, though some keywords (like "client") have been changed. Paths and response formats have also been changed to support the federation-specific requirements.
turt2live
force-pushed
the
travis/media-auth
branch
from
d8c4975
to
70e70cb
Compare
This was referenced Jun 11, 2024
Closed
zecakeh
reviewed
Jun 11, 2024
| description: "**Required.** The bytes for the thumbnail." | ||
| image/png: | ||
| schema: | ||
| x-changedInMatrixVersion: |
There was a problem hiding this comment.
Given that this endpoint is new, this and the x-addedInMatrixVersion for the other animated image formats shouldn't be needed?
There was a problem hiding this comment.
It may depend on whether we see these as truly new endpoints, or as modifications of the existing ones. This PR picks both.
Johennes
reviewed
Jun 11, 2024
1 task
dbkr
approved these changes
Jun 13, 2024
turt2live
commented
Jun 13, 2024
3 tasks
53 tasks
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per MSC3916 (markdown)
Fixes #313
Fixes #870
Known implementation issues:
Reviewable commit-by-commit (recommended)
Preview: https://pr1858--matrix-spec-previews.netlify.app