Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login/register endpoints say the device_id and stuff aren't required in the response #676

Closed
turt2live opened this issue Aug 7, 2020 · 2 comments · Fixed by #1210
Closed

Login/register endpoints say the device_id and stuff aren't required in the response #676

turt2live opened this issue Aug 7, 2020 · 2 comments · Fixed by #1210
Labels
A-Client-Server Issues affecting the CS API spec-bug Something which is in the spec, but is wrong

Comments

@turt2live
Copy link
Member

This is very much wrong
@joepie91
Copy link

joepie91 commented Aug 7, 2020

Same for register endpoint.

@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@turt2live turt2live added spec-bug Something which is in the spec, but is wrong A-Client-Server Issues affecting the CS API labels May 31, 2022
@turt2live turt2live changed the title Login endpoint says the device_id and stuff isn't required in the response Login/register endpoints say the device_id and stuff aren't required in the response Aug 9, 2022
@anoadragon453
Copy link
Member

Same for register endpoint.

For /register, the spec currently says that device_id and access_token are only required if inhibit_login in the request is false. Synapse also follows this advice.

@anoadragon453 anoadragon453 mentioned this issue Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Client-Server Issues affecting the CS API spec-bug Something which is in the spec, but is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require access_token, device_id and user_id fields in /login response matrix-org/matrix-spec
3 participants
@turt2live @anoadragon453 @joepie91