Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationData requires type but fallback forbids using type #888

Closed
krille-chan opened this issue Aug 30, 2021 · 0 comments · Fixed by #989
Closed

AuthenticationData requires type but fallback forbids using type #888

krille-chan opened this issue Aug 30, 2021 · 0 comments · Fixed by #989
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@krille-chan
Copy link

Link to problem area: https://spec.matrix.org/unstable/client-server-api/#client-behaviour-1-1

Issue
If I want to use the delete_device endpoint:
https://spec.matrix.org/unstable/client-server-api/#post_matrixclientr0delete_devices

I first send this without the auth object in the JSON and then, when using SSO, I would like to use the fallback for authentication:
https://spec.matrix.org/unstable/client-server-api/#sso-during-user-interactive-authentication

But the spec says here:

Once the flow has completed, the client retries the request with the session only.

and indeed Element web is sending:

{
  "auth": {
    "session": "xxxxx"
  },
  "devices": [
    "QBUAZIFURK",
    "AUIECTSRND"
  ]
}

and this works but in the documentation of the delete_device endpoint we have:

type | string | Required: The login type that the client is attempting to complete.

Expected behaviour
Making the type no longer required may fix this but would lead to that it would be allowed send empty JSON objects in auth and I dont know if this would be a good idea.

@krille-chan krille-chan added the spec-bug Something which is in the spec, but is wrong label Aug 30, 2021
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant