Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.call.answer sample has an invalid field. #931

Closed
Dominaezzz opened this issue Nov 21, 2021 · 1 comment · Fixed by #1054
Closed

m.call.answer sample has an invalid field. #931

Dominaezzz opened this issue Nov 21, 2021 · 1 comment · Fixed by #1054
Labels
aesthetic A suggestion or issue relating to the representation of the spec

Comments

@Dominaezzz
Copy link
Contributor

Link to problem area:
See the lifetime field here,
https://github.com/matrix-org/matrix-doc/blob/8d9a67d9f64c51be3e8465d7db1f1de5f47faa7a/data/event-schemas/examples/m.call.answer.yaml#L4-L12
it's not actually in the schema.
https://github.com/matrix-org/matrix-doc/blob/8d9a67d9f64c51be3e8465d7db1f1de5f47faa7a/data/event-schemas/schema/m.call.answer.yaml#L8-L38

Issue

Correct the sample or the schema.

@Dominaezzz Dominaezzz added the aesthetic A suggestion or issue relating to the representation of the spec label Nov 21, 2021
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 2, 2022
@KitsuneRal
Copy link
Member

Ftr, after checking across a couple of Element implementations: lifetime seems to be an accidental entry in the example and should not be a part of the specced event content. It's also pretty hard to devise why it would be needed in an answer event even in theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aesthetic A suggestion or issue relating to the representation of the spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants