Add support for Slack notifications #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@awesome-manuel : thanks for contributing this. Unfortunately it's conflicted with our switch to go modules (#31) and the CI wasn't working at the time. would you be able to update the patch? |
Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
|
@richvdh Updated |
richvdh
approved these changes
Aug 27, 2019
| } | ||
| func (s *submitServer) submitGithubIssue(ctx context.Context, p parsedPayload, listingURL string, resp *submitResponse) error { | ||
| if s.ghClient == nil { | ||
| log.Println("GH issue submission disabled") |
There was a problem hiding this comment.
For the record: generally I prefer an early return to lots of else statements (hence return nil here), though I'm aware of counterarguments to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.