Serve a tarball containing the contents of a given directory. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to get all logs for a given bug; preventing users needing to run scripts to download all files. - we cannot make the link exist in the directory listing as there are scripts that automate downloads which would pick this up. - Unsure if "?format=tar.gz" is the right option to enable this; I couldn't think of something easy to do but hard to not get picked up by existing automation, and wouldn't conflict with existing filenames.
richvdh
requested changes
Feb 10, 2022
There was a problem hiding this comment.
looks generally sensible.
Suggestions:
- document this at https://github.com/matrix-org/rageshake#get-apilisting
- add a link to the tarball from the GH issue, so that there is a direct link for new rageshakes.
richvdh
reviewed
Feb 10, 2022
richvdh
reviewed
Feb 10, 2022
|
Another suggestion: use a completely different endpoint (eg |
…tter, add documentation.
I thought about this; my logic is that if you are looking at a directory listing, it's easier to add a ?format=tar.gz on the end than change endpoint. |
|
Oh, and explicitly not adding the tarball to the github issues for now, i want to get the ability to download working in production before we start scattering links to it (in case we do want to change it to /archive or whatever) |
richvdh
approved these changes
Feb 22, 2022
| log.Println("Serving directory listing of", path) | ||
| http.ServeFile(w, r, path) | ||
| return | ||
| serveDirectory(w, r, path) | ||
| } |
There was a problem hiding this comment.
this needs a return ? (or you need to guard the rest of it with an else)
logserver.go
Outdated
| } | ||
| log.Println("Serving directory listing of", path) | ||
| http.ServeFile(w, r, path) | ||
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to get all logs for a given bug; preventing users
needing to run scripts to download all files.
we cannot make the link exist in the directory listing as there are scripts
that automate downloads which would pick this up.
Unsure if "?format=tar.gz" is the right option to enable this; I couldn't think
of something easy to do but hard to not get picked up by existing automation, and
wouldn't conflict with existing filenames. Suggestions welcome.