Persist prefix as a unique id in rageshakes #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This listing needs to be unique for the rageshake to be stored to disk, so can be relied upon in future to be unique(enough) for other services working with the rageshake.
richvdh
reviewed
Apr 11, 2022
| dfilename := strings.Trim(r.URL.Path,"/") | ||
| dfilename = strings.Replace(dfilename, "/","_",-1) | ||
| dfilename := strings.Trim(r.URL.Path, "/") | ||
| dfilename = strings.Replace(dfilename, "/", "_", -1) |
There was a problem hiding this comment.
for future reference: it would be great to put this sort of reformatting in a separate PR, so that we can easily see what's changing and what's not.
michaelkaye
force-pushed
the
michaelk/persist_unique_id_in_shakes
branch
from
9b0370b
to
79454de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rageshakes are too numerous for just uploading to github any more.
The generic webhook (and other) mechanism are able to track a greater volume of requests than simply uploading to github; however this means that we are going to be unable to use the issue ID generated by the github upload to track the rageshake.
We do create a unique ID for the on-disk rageshake, we expose this prefix as an ID in the objects we send onwards via the generic webhook API, which can then be used in external systems to uniquely identify this rageshake.
Technically this isn't any information that isn't in the ListingURL already, but i feel having a separate parameter storing the unique ID (such that it can evolve separately from the listingURL) is the right way to go.