Proxy cannot communicate DM room becoming a non-DM

[DMRobertson]

The field is a bool, serialised as omitempty

sliding-sync/sync3/room.go

Line 21 in ce99d0f

IsDM bool `json:"is_dm,omitempty"`

which means that a transition true -> false will never be signalled to clients.

In practice nobody changes the DMness of rooms, so this is unlikely to matter.

AFAICS this is where the value that clients will see is set:

sliding-sync/sync3/handler/connstate.go

Line 684 in 7e48426

IsDM: userRoomData.IsDM,

(indeed there are no other writes to sync3.Room.IsDM).

The corresponding field on UserRoomData is updated when the user cache sees an invite or an "m.direct" room account data event, which seems sensible.

[DMRobertson]

To fix: easy mode is to remove omitempty. Then we'd keep sending down is_dm: false. But we must presumably send down is_dm: true all the time today, so that's fine.

Hard mode is to change sync3.Room.IsDM to be a *bool and only set it to a nonnil value if there is a change in field to report.